The ability to reply to discussions is limited to PRO members. Want to join in the discussion? Click here to subscribe now.

Getting a Pull Request Merged and Wrapping up

Getting a Pull Request Merged and Wrapping up

1:13
Let’s look at the GitHub commits and list of contributors now that our pull request has been merged. And we’ll wrap this series up with a few tips. Feel free to practice on [stack-overflow-copy-paste](https://github.com/eggheadio-github/stack-overflow-copy-paste), and see the Pull Request demonstrated in this lesson [here](https://github.com/eggheadio-github/stack-overflow-copy-paste/pull/9).
Watch this lesson now
Avatar
egghead.io

Let’s look at the GitHub commits and list of contributors now that our pull request has been merged. And we’ll wrap this series up with a few tips. Feel free to practice on stack-overflow-copy-paste, and see the Pull Request demonstrated in this lesson here.

Avatar
David

I really love this series, especially with the very real repo for us to practice. Sometimes, even for people very experienced with dev, it's nice to have a "best practices" course so we are aware of how to respect others' projects and contribute in a way that is easiest for the very busy maintainers. Cheers!

In reply to egghead.io
Avatar
Khaled

Love the serie, thanks a lot . But I have a small question, when forcing push, won't this break semantic release process and require you to make a manual publish ?

Avatar
Kent C.

I'm glad you like the series! You're right to be concerned about force pushing. It can be dangerous and it can mess up semantic-release. But this is only true when you force push to the master branch. You can force push to any other branch just fine and because semantic-release doesn't do anything with those branches, it doesn't make a difference.

As a related note, I recommend that you protect your master branch from force pushes: https://help.github.com/articles/about-protected-branches/

In reply to Khaled
Avatar
Mike

Love this series, because of this series I filed my first issue on GitHub and I plan on creating my own repo. Thanks!

HEY, QUICK QUESTION!
Joel's Head
Why are we asking?